Skip to content

Update dpnp submodule call erf, synchronize dpnp array creation#356

Merged
jharlow-intel merged 1 commit into
IntelPython:mainfrom
vchamarthi:dpnp-fixes
Jun 16, 2026
Merged

Update dpnp submodule call erf, synchronize dpnp array creation#356
jharlow-intel merged 1 commit into
IntelPython:mainfrom
vchamarthi:dpnp-fixes

Conversation

@vchamarthi

@vchamarthi vchamarthi commented May 19, 2026

Copy link
Copy Markdown
Contributor

This pull request adds explicit synchronization steps after array computations in several benchmark implementations of dpnp to ensure that results are correctly written to memory. The main changes involve calling np.synchronize_array_data on output arrays at the end of each computation function.

Updated calls to the error function in black_scholes_dpnp.py to use np.scipy.special.erf for compatibility.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@jharlow-intel jharlow-intel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jharlow-intel jharlow-intel enabled auto-merge June 16, 2026 21:41
@jharlow-intel jharlow-intel disabled auto-merge June 16, 2026 21:42
@jharlow-intel

Copy link
Copy Markdown
Collaborator

We super need to fix the CI, but not this PR (:

@jharlow-intel jharlow-intel merged commit 56319bb into IntelPython:main Jun 16, 2026
0 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants